Fix DEVELOPER_README.md link in Quick Start #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Prometheus Connector," and the version of the Prometheus connector, has been added to the User-Agent header, before the current value in the User-Agent header, which is the AWS SDK and its version. Example from logs with DEBUG log-level: ``` User-Agent: Prometheus Connector/1.1.0 aws-sdk-go/1.35.7 (go1.21.1; darwin; arm64) ``` Also, details on what the `User-Agent` header value is for the Prometheus Connector has been added to the README.
…-prometheus into integration
README and serverless/DEVELOPER_README have been edited and now stress one-click deployment as the best way to deploy the connector. Additionally, various grammatical, spelling, whitespace, and markdown formatting issues have been fixed. British English has been favoured. An outdated image was also changed. GETTING_STARTED has been removed and its verification section has been moved to README.
…-prometheus into integration
- Broken or outdated links have been fixed. - `RELEASE.md` has been updated with instructions for using the seven public S3 buckets and `template.yml`. - All references to version `1.1.0` have been changed to `1.0.0`.
…-prometheus into integration
- `go1.x` runtime is no longer supported for Lambda functions, causing deployments to fail, this has been updated to `provided.al2023`. - The connector version in `template.yml` has been changed from `1.1.0` to `1.0.0`. - Handler has been changed to `bootstrap` to match the instructions to migrate from `go1.x` to `provided.al2023`. - The template will get the Lambda function code from the public bucket matching `AWS::Region`. - `package.py` now names the binary `bootstrap`, but still packages the binary and documentation in an archive named `timestream-prometheus-connect-<os>-<arch>-<version>`.
…-prometheus into integration
…-prometheus into integration
forestmvey
pushed a commit
to forestmvey/amazon-timestream-connector-prometheus
that referenced
this pull request
May 7, 2024
* Add User-Agent documentation to README * Add User-Agent header value * Revise documentation README and serverless/DEVELOPER_README have been edited and now stress one-click deployment as the best way to deploy the connector. Additionally, various grammatical, spelling, whitespace, and markdown formatting issues have been fixed. British English has been favoured. An outdated image was also changed. GETTING_STARTED has been removed and its verification section has been moved to README. * Fix broken & outdated links & revamp RELEASE.md - Broken or outdated links have been fixed. - `RELEASE.md` has been updated with instructions for using the seven public S3 buckets and `template.yml`. - All references to version `1.1.0` have been changed to `1.0.0`. * Update template Go version & connector version in template - `go1.x` runtime is no longer supported for Lambda functions, causing deployments to fail, this has been updated to `provided.al2023`. - The connector version in `template.yml` has been changed from `1.1.0` to `1.0.0`. - Handler has been changed to `bootstrap` to match the instructions to migrate from `go1.x` to `provided.al2023`. - The template will get the Lambda function code from the public bucket matching `AWS::Region`. - `package.py` now names the binary `bootstrap`, but still packages the binary and documentation in an archive named `timestream-prometheus-connect-<os>-<arch>-<version>`. * Fix DEVELOPER_README.md link in Quick Start
forestmvey
pushed a commit
to forestmvey/amazon-timestream-connector-prometheus
that referenced
this pull request
May 7, 2024
* Add User-Agent documentation to README * Add User-Agent header value * Revise documentation README and serverless/DEVELOPER_README have been edited and now stress one-click deployment as the best way to deploy the connector. Additionally, various grammatical, spelling, whitespace, and markdown formatting issues have been fixed. British English has been favoured. An outdated image was also changed. GETTING_STARTED has been removed and its verification section has been moved to README. * Fix broken & outdated links & revamp RELEASE.md - Broken or outdated links have been fixed. - `RELEASE.md` has been updated with instructions for using the seven public S3 buckets and `template.yml`. - All references to version `1.1.0` have been changed to `1.0.0`. * Update template Go version & connector version in template - `go1.x` runtime is no longer supported for Lambda functions, causing deployments to fail, this has been updated to `provided.al2023`. - The connector version in `template.yml` has been changed from `1.1.0` to `1.0.0`. - Handler has been changed to `bootstrap` to match the instructions to migrate from `go1.x` to `provided.al2023`. - The template will get the Lambda function code from the public bucket matching `AWS::Region`. - `package.py` now names the binary `bootstrap`, but still packages the binary and documentation in an archive named `timestream-prometheus-connect-<os>-<arch>-<version>`. * Fix DEVELOPER_README.md link in Quick Start
forestmvey
pushed a commit
to forestmvey/amazon-timestream-connector-prometheus
that referenced
this pull request
May 7, 2024
* Add User-Agent documentation to README * Add User-Agent header value * Revise documentation README and serverless/DEVELOPER_README have been edited and now stress one-click deployment as the best way to deploy the connector. Additionally, various grammatical, spelling, whitespace, and markdown formatting issues have been fixed. British English has been favoured. An outdated image was also changed. GETTING_STARTED has been removed and its verification section has been moved to README. * Fix broken & outdated links & revamp RELEASE.md - Broken or outdated links have been fixed. - `RELEASE.md` has been updated with instructions for using the seven public S3 buckets and `template.yml`. - All references to version `1.1.0` have been changed to `1.0.0`. * Update template Go version & connector version in template - `go1.x` runtime is no longer supported for Lambda functions, causing deployments to fail, this has been updated to `provided.al2023`. - The connector version in `template.yml` has been changed from `1.1.0` to `1.0.0`. - Handler has been changed to `bootstrap` to match the instructions to migrate from `go1.x` to `provided.al2023`. - The template will get the Lambda function code from the public bucket matching `AWS::Region`. - `package.py` now names the binary `bootstrap`, but still packages the binary and documentation in an archive named `timestream-prometheus-connect-<os>-<arch>-<version>`. * Fix DEVELOPER_README.md link in Quick Start
forestmvey
pushed a commit
to forestmvey/amazon-timestream-connector-prometheus
that referenced
this pull request
May 7, 2024
* Add User-Agent documentation to README * Add User-Agent header value * Revise documentation README and serverless/DEVELOPER_README have been edited and now stress one-click deployment as the best way to deploy the connector. Additionally, various grammatical, spelling, whitespace, and markdown formatting issues have been fixed. British English has been favoured. An outdated image was also changed. GETTING_STARTED has been removed and its verification section has been moved to README. * Fix broken & outdated links & revamp RELEASE.md - Broken or outdated links have been fixed. - `RELEASE.md` has been updated with instructions for using the seven public S3 buckets and `template.yml`. - All references to version `1.1.0` have been changed to `1.0.0`. * Update template Go version & connector version in template - `go1.x` runtime is no longer supported for Lambda functions, causing deployments to fail, this has been updated to `provided.al2023`. - The connector version in `template.yml` has been changed from `1.1.0` to `1.0.0`. - Handler has been changed to `bootstrap` to match the instructions to migrate from `go1.x` to `provided.al2023`. - The template will get the Lambda function code from the public bucket matching `AWS::Region`. - `package.py` now names the binary `bootstrap`, but still packages the binary and documentation in an archive named `timestream-prometheus-connect-<os>-<arch>-<version>`. * Fix DEVELOPER_README.md link in Quick Start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
DEVELOPER_READMEhas been fixed in "Quick Start."By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.