Add Default Ingestion Configuration Logging and Update Documentation to Reflect Runtime Naming Convention #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to use the bootstrap naming convention. Add info logging about which database, table, and region are configured for the Prometheus Connector. Signed-off-by: forestmvey <forestv@bitquilltech.com>
…ambda invocation. Signed-off-by: forestmvey <forestv@bitquilltech.com>
Signed-off-by: forestmvey <forestv@bitquilltech.com>
Signed-off-by: forestmvey <forestv@bitquilltech.com>
Signed-off-by: forestmvey <forestv@bitquilltech.com>
…s are set. Signed-off-by: forestmvey <forestv@bitquilltech.com>
Signed-off-by: forestmvey <forestv@bitquilltech.com>
…ntation Add Default Ingestion Configuration Logging and Update Documentation to Reflect New Naming Convention
alexey-temnikov
approved these changes
Mar 27, 2024
forestmvey
added a commit
to forestmvey/amazon-timestream-connector-prometheus
that referenced
this pull request
May 7, 2024
…to Reflect Runtime Naming Convention (awslabs#49) * Change all references for pre-compiled binaries in the documentation to use the bootstrap naming convention. Add info logging about which database, table, and region are configured for the Prometheus Connector. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Change configuration default logs to debug level, and added log for lambda invocation. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Updating logs to level info for ingestion configurations. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Fix typo and grammar. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Updated log for query client in lambda handler. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Added check when running binary that default database and table values are set. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Revising initialization log format. Signed-off-by: forestmvey <forestv@bitquilltech.com> --------- Signed-off-by: forestmvey <forestv@bitquilltech.com>
forestmvey
added a commit
to forestmvey/amazon-timestream-connector-prometheus
that referenced
this pull request
May 7, 2024
…to Reflect Runtime Naming Convention (awslabs#49) * Change all references for pre-compiled binaries in the documentation to use the bootstrap naming convention. Add info logging about which database, table, and region are configured for the Prometheus Connector. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Change configuration default logs to debug level, and added log for lambda invocation. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Updating logs to level info for ingestion configurations. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Fix typo and grammar. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Updated log for query client in lambda handler. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Added check when running binary that default database and table values are set. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Revising initialization log format. Signed-off-by: forestmvey <forestv@bitquilltech.com> --------- Signed-off-by: forestmvey <forestv@bitquilltech.com>
forestmvey
added a commit
to forestmvey/amazon-timestream-connector-prometheus
that referenced
this pull request
May 7, 2024
…to Reflect Runtime Naming Convention (awslabs#49) * Change all references for pre-compiled binaries in the documentation to use the bootstrap naming convention. Add info logging about which database, table, and region are configured for the Prometheus Connector. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Change configuration default logs to debug level, and added log for lambda invocation. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Updating logs to level info for ingestion configurations. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Fix typo and grammar. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Updated log for query client in lambda handler. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Added check when running binary that default database and table values are set. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Revising initialization log format. Signed-off-by: forestmvey <forestv@bitquilltech.com> --------- Signed-off-by: forestmvey <forestv@bitquilltech.com>
forestmvey
added a commit
to forestmvey/amazon-timestream-connector-prometheus
that referenced
this pull request
May 7, 2024
…to Reflect Runtime Naming Convention (awslabs#49) * Change all references for pre-compiled binaries in the documentation to use the bootstrap naming convention. Add info logging about which database, table, and region are configured for the Prometheus Connector. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Change configuration default logs to debug level, and added log for lambda invocation. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Updating logs to level info for ingestion configurations. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Fix typo and grammar. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Updated log for query client in lambda handler. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Added check when running binary that default database and table values are set. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Revising initialization log format. Signed-off-by: forestmvey <forestv@bitquilltech.com> --------- Signed-off-by: forestmvey <forestv@bitquilltech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Change all references for pre-compiled binaries to use the new naming convention for having the binary named
bootstrapfor theprovided.al2023runtime.timestream-prometheus-connector-linux-amd64-1.0.0) that was used prior to the lambda runtime upgrade which now requires the binary be namedbootstrapUpdate initialization log to include which default database, table, and region the Prometheus Connector has configured for both local and lambda invocation.
Timestream write connection is initialized (Database: database-name, Table: table-name, Region: region-name)Added a check to ensure when executing the binary that the default database and table values must be set.
--default-databaseor--default-tablethe following error will be raised:timestream-prometheus-connector: error: The default database value must be set through the flag <missing-table-or-database-flag>Added initialization log to notify users that the connector is ready to begin ingestion and query requests.
The Prometheus Connector is now ready to begin serving ingestion and query requests.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.