Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lambda timeout & refactor timeout names #65

Merged

Conversation

trevorbonas
Copy link
Contributor

Issue #, if available: N/A

Description of changes:

  • The Lambda function now has a Timeout value, with a default of 30 seconds. This is the amount of time the connector has to process a request. This was previously only 3 seconds since Timeout was not defined.
  • TimeoutInMillis has been renamed to ApiGatewayTimeoutInMillis, to be clearer.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

*Issue #, if available:* N/A

*Description of changes:*
- The Lambda function now has a `Timeout` value, with a default of `30` seconds. This is the amount of time the connector has to process a request. This was previously only `3` seconds since `Timeout` was not defined.
- `TimeoutInMillis` has been renamed to `ApiGatewayTimeoutInMillis`, to be clearer.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
@trevorbonas trevorbonas requested a review from forestmvey May 15, 2024 22:02
Copy link
Contributor

@forestmvey forestmvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested and validated ingestion and query through the deployed connector. Looks good!

@forestmvey forestmvey merged commit 3cfa197 into awslabs:main May 15, 2024
6 checks passed
@forestmvey forestmvey deleted the integ-cloudformation-improvements branch May 15, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants