Enable the Dev Portal to use an existing Cognito User Pool #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielesalvatore
requested review from
a-tan,
bejos-zz,
etsung-aws,
MynockSpit,
nitishdayal and
echo-bravo-yahoo
as code owners
|
+1 this would be great to have when setting up the dev portal and having an existing user pool/identity provider setup |
|
This feature should be merged into the main branch. |
|
@danielesalvatore - This has been in there for a while - Was this ever merged to the main branch? Anybody else got this working even if it is not merged to the main? Thanks |
|
Hello @talipini I don't think it was ever merged |
|
@danielesalvatore Could you rebase and resolve the merge conflicts? |
ghost
requested review from
aws-amit,
ichuckyi,
lloypark and
zil-aws
and removed request for
echo-bravo-yahoo,
MynockSpit,
a-tan,
nitishdayal,
bejos-zz,
etsung-aws and
jiyou95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Enable the Dev Portal to use an existing Cognito User Pool instead of creating a new one.
Description of changes:
In a situation in which the Developer Portal is adopted by users that already have a AWS setup in place, and in particular an existing, already configured (federations, etc.), customised (UI look&feel, etc.) Cognito User Pool, is now possible to let the Developer Portal to rely on it for the authentication/registration/user manager processed.
In order to implement the feature, the following section has been modified:
/dev-portal/deployer-config.js: to enable the user to pass the optionalcognitoUserPoolparam/dev-portal/scripts/deploy-stack.js: to pass thecognitoUserPoolto the stack Cloud Formation template./cloudformation/template.yaml: to implement the conditional logic to use the existingcognitoUserPoolinstead of creating a new one - while thecognitoUserPoolis passed the other User Pool is not created at all./dev-portal/README.md: to document the new parameter.While passing an existing User Pool, all the authorisation mechanisms of the stack are still preserved. In particular:
It is important to notice that, to re-use the already existing parameter
cognitoDomainNameand the fact that within the Cloud Formation Template is intended asCognitoDomainNameOrPrefix, the following logic as been implemented:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.