Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ProcessProvider to ProfileProvider #245

Merged
merged 4 commits into from
Aug 4, 2024
Merged

Add ProcessProvider to ProfileProvider #245

merged 4 commits into from
Aug 4, 2024

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Jul 31, 2024

Description of changes:

  • The current implementation breaks the use case of profileA assuming the role of profileB, and profileB uses process credentials. To fix that, make the ProcessProvider part of the profile provider.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.41%. Comparing base (d789525) to head (8f3bb57).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
- Coverage   80.44%   80.41%   -0.03%     
==========================================
  Files          33       33              
  Lines        6038     6034       -4     
==========================================
- Hits         4857     4852       -5     
- Misses       1181     1182       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waahm7 waahm7 marked this pull request as ready for review July 31, 2024 20:56
@waahm7 waahm7 merged commit 52bf591 into main Aug 4, 2024
30 checks passed
@waahm7 waahm7 deleted the fix-profile-process branch August 4, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants