[OSX] Hardcoded CoreFoundation path in aws-c-common-targets.cmake #510
Labels
closing-soon
This issue will automatically close in 5 days unless further comments are made.
Comments
|
Hey quick question, in aws-c-common’s cmake config file, could you add a find_dependency call to CoreFoundation, and see if your consumer re-resolves at link time?
…Sent from my iPhone
On Sep 27, 2019, at 8:15 AM, Krisztián Szűcs ***@***.***> wrote:
I don't have Xcode installed locally, only command line tools, so the linker cannot locate CoreFoundation:
set_target_properties(AWS::aws-c-common PROPERTIES
INTERFACE_COMPILE_DEFINITIONS "AWS_COMMON_USE_IMPORT_EXPORT"
INTERFACE_COMPILE_OPTIONS "-pthread"
INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
INTERFACE_LINK_LIBRARIES "-pthread;pthread;/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/System/Library/Frameworks/CoreFoundation.framework"
)
A temporary solution is overriding it.
What platform/OS are you using?
OSX Mojave
Which version of the SDK?
Installed by home-brew:
aws-sdk-cpp: stable 1.7.180 (bottled), HEAD
AWS SDK for C++
https://github.com/aws/aws-sdk-cpp
/usr/local/Cellar/aws-sdk-cpp/1.7.180 (22,152 files, 426.2MB)
Poured from bottle on 2019-09-18 at 15:36:12
From: https://github.com/Homebrew/homebrew-core/blob/master/Formula/aws-sdk-cpp.rb
Original issue: aws/aws-sdk-cpp#1245
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Hey Jonathan, just saw your response. I'll try to check it in the upcoming days. |
graebm
added
the
closing-soon
xhochy
added a commit
to xhochy/aws-c-common
that referenced
this issue
Sep 23, 2020
This would otherwise hardcode the Xcode version and we would have to recompile after each Xcode update. Fixes awslabs#510
|
Made a PR to fix this: #700 |
xhochy
added a commit
to xhochy/aws-c-common
that referenced
this issue
Nov 24, 2020
This would otherwise hardcode the Xcode version and we would have to recompile after each Xcode update. Fixes awslabs#510
bretambrose
added a commit
that referenced
this issue
Mar 11, 2021
* Don't hardcode the CoreFoundation path This would otherwise hardcode the Xcode version and we would have to recompile after each Xcode update. Fixes #510 * Address review comments Co-authored-by: Jonathan M. Henson <henso@amazon.com> Co-authored-by: Bret Ambrose <bretambrose@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I don't have Xcode installed locally, only command line tools, so the linker cannot locate CoreFoundation:
A temporary solution is overriding it.
What platform/OS are you using?
OSX Mojave
Which version of the SDK?
Installed by home-brew:
Original issue: aws/aws-sdk-cpp#1245
The text was updated successfully, but these errors were encountered: