Add a way to skip a test #1012
Merged
Add a way to skip a test #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1012 +/- ##
==========================================
- Coverage 81.97% 81.95% -0.03%
==========================================
Files 52 52
Lines 5569 5568 -1
==========================================
- Hits 4565 4563 -2
- Misses 1004 1005 +1 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
xiazhvera
commented
Apr 7, 2023
| @@ -62,9 +62,24 @@ static int s_cunit_failure_message0( | |||
| s_cunit_failure_message0(FAIL_PREFIX, func, file, line, format, #__VA_ARGS__) | |||
|
|
|||
| static int total_failures; | |||
| static int total_skip; | |||
There was a problem hiding this comment.
The value reserved to record the total skipped tests count. Current not in use.
xiazhvera
commented
Apr 12, 2023
|
|
||
| #define SUCCESS (0) | ||
| #define FAILURE (-1) | ||
| #define SKIP (1) |
There was a problem hiding this comment.
The skip code returned to cmake has to be in range [0,255]. Refer to cmake doc: https://cmake.org/cmake/help/latest/prop_test/SKIP_RETURN_CODE.html
DmitriyMusatkin
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The test case can be skipped if it returned AWS_OP_SKIP.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.