Avoiding allocating a handle in the Windows RNG. #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR uses the `BCRYPT_USE_SYSTEM_PREFERRED_RNG` option in the call to `BCryptGenRandom` to avoid allocating an algorithm handle, and simplifying the code a bit.
|
Can you please explain why you would want to avoid allocating an algorithm handle? |
jmklix
added
the
response-requested
|
Greetings! It looks like this PR hasn’t been active in longer than a week, add a comment or an upvote to prevent automatic closure, or if the issue is already closed, please feel free to open a new one. |
github-actions
bot
added
the
closing-soon
github-actions
bot
removed
closing-soon
graebm
approved these changes
Jul 29, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR uses the
BCRYPT_USE_SYSTEM_PREFERRED_RNGoption in the call toBCryptGenRandomto avoid allocating an algorithm handle, and simplifying the code a bit.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.