Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional priority queue related APIs #1067

Merged
merged 10 commits into from
Oct 27, 2023
Merged

Conversation

bretambrose
Copy link
Contributor

@bretambrose bretambrose commented Oct 25, 2023

  • aws_priority_queue_node_init - so that we're not adding magic SIZE_MAXs everywhere it's used
  • aws_priority_queue_node_is_in_queue - so that we're not adding magic SIZE_MAXs everywhere it's used
  • aws_priority_queue_clear - because sometimes you want to clear the queue without deallocating and re-initing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ce8c56) 83.20% compared to head (f018a06) 83.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1067   +/-   ##
=======================================
  Coverage   83.20%   83.20%           
=======================================
  Files          55       55           
  Lines        5715     5729   +14     
=======================================
+ Hits         4755     4767   +12     
- Misses        960      962    +2     
Files Coverage Δ
source/priority_queue.c 91.08% <100.00%> (+0.71%) ⬆️
source/task_scheduler.c 77.96% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

include/aws/common/priority_queue.h Outdated Show resolved Hide resolved
@bretambrose bretambrose changed the title Add an init function for priority queue node structures Add additional priority queue related APIs Oct 25, 2023
@bretambrose bretambrose merged commit a0689cf into main Oct 27, 2023
51 checks passed
@bretambrose bretambrose deleted the PriorityQueueNodeInit branch October 27, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants