Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memtracer bad assumptions on the size of stack trace #1122

Merged
merged 5 commits into from
Jun 5, 2024

Conversation

DmitriyMusatkin
Copy link
Contributor

Issue #, if available:

Description of changes:
Fix memtracer assumptions on the size of stack. With optimizations on, there is no guarantees how many frames we get back. So handle any size of stack gracefully.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.08%. Comparing base (06cf4d8) to head (e270eed).

Files Patch % Lines
source/memtrace.c 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1122      +/-   ##
==========================================
- Coverage   83.12%   83.08%   -0.05%     
==========================================
  Files          56       56              
  Lines        5755     5758       +3     
==========================================
  Hits         4784     4784              
- Misses        971      974       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

source/memtrace.c Outdated Show resolved Hide resolved
@DmitriyMusatkin DmitriyMusatkin merged commit d2d5da4 into main Jun 5, 2024
52 checks passed
@DmitriyMusatkin DmitriyMusatkin deleted the stacks branch June 5, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants