disable optimization was not working #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return aws_mem_acquire(allocator, size); | ||
| } | ||
|
|
||
| AWS_NO_INLINE void *s_alloc_2(struct aws_allocator *allocator, size_t size) { | ||
| AWS_PREVENT_OPTIMIZATION; |
There was a problem hiding this comment.
do we use this anywhere else? should we just update this macro?
There was a problem hiding this comment.
it's not used anywhere else, and it's working differently than the previous way, we need two macros now one for start disable and another one for end.
But, yeah, it's only used here, so, just got rid of the macro instead.
DmitriyMusatkin
approved these changes
Jun 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1123 +/- ##
=======================================
Coverage 83.07% 83.07%
=======================================
Files 56 56
Lines 5756 5756
=======================================
Hits 4782 4782
Misses 974 974 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
__asm__ __volatile__("" ::: "memory")doesn't prevent GCC 7.5.0 to optimize those functions on arm64, and result in a test failureDescription of changes:
Use another way to disable optimization.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.