Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default thread options for windows to not pin to any cpu_id #1126

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Jun 18, 2024

Issue #, if available:

Description of changes:

  • cpu_id should be -1 if we don't want to pin to any cpu_id

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@waahm7 waahm7 marked this pull request as draft June 18, 2024 23:30
@waahm7 waahm7 changed the title WIP | fix default thread options for windows Fix default thread options for windows to not pin to any cpu_id Jun 19, 2024
@waahm7 waahm7 marked this pull request as ready for review June 19, 2024 22:44
Copy link
Contributor

@graebm graebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😳

@waahm7 waahm7 merged commit 0cb24e1 into main Jun 20, 2024
52 checks passed
@waahm7 waahm7 deleted the fix-null-and-shutdown-callback branch June 20, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants