Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cbor follow up fixes #1130

Merged
merged 9 commits into from
Jun 19, 2024
Merged

Cbor follow up fixes #1130

merged 9 commits into from
Jun 19, 2024

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Jun 19, 2024 •
edited
Loading

Issue #, if available:

  • Fixes after merge
    • typo: AWS_CBOR_TYPE_UNKOWN->AWS_CBOR_TYPE_UNKNOWN
    • aws_cbor_decoder_new takes aws_byte_cursor by value instead of pointer
    • renaming aws_cbor_decoder_release -> aws_cbor_decoder_destroy
    • Fixed a bug of aws_byte_buf_reserve_smart that forgets to check if no expansion needs or not and added test for it
  • for sure, shall not make a PR that is too long and sit in review for too long.

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@TingDaoK TingDaoK marked this pull request as ready for review June 19, 2024 21:07
@TingDaoK TingDaoK merged commit a400552 into cbor-main Jun 19, 2024
52 checks passed
@TingDaoK TingDaoK deleted the cbor-follow-up-fixes branch June 19, 2024 23:15
@TingDaoK TingDaoK mentioned this pull request Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graebm graebm graebm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TingDaoK @graebm