Add no copy api variants to json interface #1138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
There are several json apis that currently take key by cursor, including some heavily used apis like get_object or has_object. Since underlying lib relies on const char, that means that every one of those apis needs to make a temp copy of the key. In grand scheme of things copies are cheap, but for heavy users of json (ex. endpoint resolution) cost ends up quickly.
This PR adds const char variants for all functions taking a key to avoid a copy. And as a side bonus you can now just write get_object(json, "field_name"), which is cleaner in my opinion than having to wrap it in cursor.
Can we just make cursor version not do a copy? Not without major surgery of cJson, which internally relies on c strings a lot.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.