Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmake module for building dependencies at configuration time #1144

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

sfod
Copy link
Contributor

@sfod sfod commented Aug 8, 2024

Issue #, if available:

This functionality is needed to fix s2n-tls misconfiguration in aws-crt-* projects. See awslabs/aws-crt-cpp#648

Description of changes:

This cmake module implements a new function, prebuild_dependency, which can build a dependency at configuration time.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.82%. Comparing base (2add521) to head (d6004d3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1144   +/-   ##
=======================================
  Coverage   83.82%   83.82%           
=======================================
  Files          57       57           
  Lines        5991     5991           
=======================================
  Hits         5022     5022           
  Misses        969      969           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfod sfod merged commit 8419fe7 into main Aug 12, 2024
53 checks passed
@sfod sfod deleted the prebuild-aws-lc branch August 12, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants