Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The XML API was hard to use right, leading to bugs like this: #328
Description of changes:
aws_xml_node_as_body()
weren't being checked for error.aws_xml_get_top_level_tag()andaws_xml_get_top_level_tag_with_root_name()withaws_xml_get_body_at_path()
aws_xml_get_top_level_tag()didn't check the name of the root nodeaws_xml_get_top_level_tag_with_root_name()was clunky to use (IMHO)aws_byte_cursor
instead ofaws_string
, the user was usually just deleting it afterwards, which made their error-handling more complicated.aws_s3_list_objects_operation_new()andaws_s3_initiate_list_parts()aws_replace_quote_entities()
returnsaws_byte_buf
by value, instead of as out-paramaws_byte_cursor
by value, instead takingaws_string *
oraws_byte_buf *
oraws_byte_cursor *
by pointerBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.