Skip to content

Commit

Permalink
refactor(ecs): Asset ContainerImage no longer takes Construct argumen…
Browse files Browse the repository at this point in the history
…ts (#2906)

Turn the `ContainerImage` into the standard integration pattern. It is
no longer a construct itself, but creates subconstructs during `bind`.

BREAKING CHANGE:

* **ecs**: `ContainerImage.fromAsset()` now takes only build directory
  directly (no need to pass `scope` or `id` anymore).
  • Loading branch information
rix0rrr authored Jun 18, 2019
1 parent e00c427 commit 8f400e7
Show file tree
Hide file tree
Showing 17 changed files with 435 additions and 449 deletions.
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-codebuild/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ Alternatively, you can specify a custom image using one of the static methods on
Hub.
* Use `.fromEcrRepository(repo[, tag])` to reference an image available in an
ECR repository.
* Use `.fromAsset(this, id, { directory: dir })` to use an image created from a
* Use `.fromAsset(directory)` to use an image created from a
local asset.

The following example shows how to define an image from a Docker asset:
Expand Down
Loading

0 comments on commit 8f400e7

Please sign in to comment.