Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: clean up build scripts #119

Merged
merged 4 commits into from
Oct 25, 2024
Merged

misc: clean up build scripts #119

merged 4 commits into from
Oct 25, 2024

Conversation

lauzadis
Copy link
Member

@lauzadis lauzadis commented Oct 23, 2024

Description of changes:

  • Remove elasticurl project
    • This was an early KMP proof of concept, compiling for JVM and Android. It's no longer necessary now that we're working on a full Kotlin/Native implementation

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

@lauzadis lauzadis marked this pull request as ready for review October 23, 2024 19:51
@lauzadis lauzadis requested a review from a team as a code owner October 23, 2024 19:51
Copy link
Contributor

@ianbotsf ianbotsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This brings the repo back down to a single module/project. Should we bump the aws-crt-kotlin project up to the top?

@lauzadis
Copy link
Member Author

lauzadis commented Oct 23, 2024

This brings the repo back down to a single module/project. Should we bump the aws-crt-kotlin project up to the top?

Good idea @ianbotsf , I'll do that in a follow-up PR. We still have two modules right now: aws-crt-kotlin and build-support which contains some KMP-specific utilities that should be refactorable into aws-kotlin-repo-tools soon

@lauzadis lauzadis merged commit 6eaf028 into kn-main Oct 25, 2024
13 of 16 checks passed
@lauzadis lauzadis deleted the kn-clean-up branch October 25, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants