Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves documentation in Package.swift regarding lack of CPU flags. #225

Merged
merged 6 commits into from
Jan 22, 2024
Merged

Improves documentation in Package.swift regarding lack of CPU flags. #225

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b15ea36
Improve comments
waahm7 Jan 22, 2024
5b545fc
improve comments
waahm7 Jan 22, 2024
16e3f25
Update comment
waahm7 Jan 22, 2024
70d02b3
Merge branch 'main' into fix-hardware-checksums
waahm7 Jan 22, 2024
7fcafcc
Change Swift PM to SwiftPM
waahm7 Jan 22, 2024
7dd344e
Merge branch 'main' into fix-hardware-checksums
waahm7 Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ var awsCCommonPlatformExcludes = ["source/android",
"source/linux/system_info.c",
"bin/"] + excludesFromAll

// includes arch/generic
// includes arch/generic because the Swift PM doesn't like the necessary compiler flags.
waahm7 marked this conversation as resolved.
Show resolved Hide resolved
awsCCommonPlatformExcludes.append("source/arch/intel")
awsCCommonPlatformExcludes.append("source/arch/arm")
#if !os(Windows)
Expand Down Expand Up @@ -143,21 +143,15 @@ var awsCChecksumsExcludes = [

// swift never uses Microsoft Visual C++ compiler
awsCChecksumsExcludes.append("source/intel/visualc")
// TODO: enable hardware acceleration https://github.com/awslabs/aws-sdk-swift/issues/867
// #if arch(arm64)
//// includes source/arm
//// TODO: look at the compiler flag in C
// awsCChecksumsExcludes.append("source/intel")
// awsCChecksumsExcludes.append("source/generic")
// #elseif arch(x86_64) || arch(i386)
//// include src/intel/asm
// awsCChecksumsExcludes.append("source/arm")
// awsCChecksumsExcludes.append("source/generic")
// #else

// Hardware accelerated checksums are disabled because Swift PM doesn't like the necessary compiler flags.
// We can add it once Swift package manager has the necessary support for CPU flags or builds C libraries
// using CMake.
// See: https://github.com/apple/swift-package-manager/issues/4555
// Also, see issue: https://github.com/awslabs/aws-sdk-swift/issues/867 before enabling hardware accelerated checksums.
// includes source/generic
awsCChecksumsExcludes.append("source/arm")
awsCChecksumsExcludes.append("source/intel")
// #endif

//////////////////////////////////////////////////////////////////////
/// aws-c-sdkutils
Expand Down