Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Terraform pipeline issue after upgrade to 4.0.0 #746

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

stemons
Copy link
Contributor

@stemons stemons commented Jul 9, 2024

Why?

Fix terraform pipeline issues after upgrade to 4.0.0. Terraform is not able to upload tf statefile to S3 bucket due to wrong definition of S3 terraform backend

Issue #744, #745

What?

Added encryption properties to terraform S3 backend.
Added permission to codebuild role in the deployment account to read AWS Organizations api


By submitting this pull request, I confirm that you can use, modify, copy, and
redistribute this contribution, under the terms of your choice.

@stemons stemons changed the title Fix issue Terraform pipeline issue after upgrade to 4.0.0 [Issue:744,745] Fix Terraform pipeline issue after upgrade to 4.0.0 Jul 9, 2024
Copy link
Collaborator

@sbkok sbkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing this fix!

@sbkok sbkok requested a review from javydekoning July 10, 2024 08:26
@sbkok sbkok added this to the v4.0.1 milestone Jul 10, 2024
@sbkok sbkok merged commit 1a495bd into awslabs:master Aug 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants