Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics): Rename leftover reference to purgeStoredMetrics() function #424

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

ijemmy
Copy link
Contributor

@ijemmy ijemmy commented Jan 6, 2022

Description of your changes

Rename the term "purge" that was missed by the PR #377

This will solve issue #423

How to verify this change

cd examples/cdk
# switch to target aws account
cdk deploy 
aws lambda invoke --function-name <function_name_should_start_with_CdkAppStack-MyFunction>
# check that the EMF is published on CloudWatch log

image

Related issues, RFCs

#377
#423

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ijemmy ijemmy requested review from flochaz and dreamorosi January 6, 2022 16:14
@github-actions github-actions bot added the bug Something isn't working label Jan 6, 2022
@flochaz
Copy link
Contributor

flochaz commented Jan 6, 2022

Will add examples testing as part of our CI/CD workflow

@dreamorosi dreamorosi merged commit 02f0eae into main Jan 6, 2022
@dreamorosi dreamorosi deleted the fix/423/renamePurge branch January 6, 2022 17:55
@dreamorosi dreamorosi linked an issue Jan 6, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Rename purgeStoredMetrics() function usage in CDK example
4 participants