feat(logger): add removeKeys functionality #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
saragerion
commented
May 25, 2022
dreamorosi
previously approved these changes
May 25, 2022
Co-authored-by: Andrea Amorosi <dreamorosi@gmail.com>
Co-authored-by: Andrea Amorosi <dreamorosi@gmail.com>
…powertools-typescript into feat/remove-log-keys
dreamorosi
approved these changes
May 27, 2022
flochaz
approved these changes
May 30, 2022
flochaz
pushed a commit
that referenced
this pull request
Jun 3, 2022
* chore: add setup-local script * feat(logger): add removeKeys functionality * chore(logger): lint fix * Update packages/logger/tests/unit/Logger.test.ts Co-authored-by: Andrea Amorosi <dreamorosi@gmail.com> * Update packages/logger/tests/unit/Logger.test.ts Co-authored-by: Andrea Amorosi <dreamorosi@gmail.com> * docs: added single command for local setup in contribuiting * chore: fixed propriety typo Co-authored-by: Andrea Amorosi <dreamorosi@gmail.com>
dreamorosi
added a commit
that referenced
this pull request
Aug 2, 2022
* chore: add setup-local script * feat(logger): add removeKeys functionality * chore(logger): lint fix * Update packages/logger/tests/unit/Logger.test.ts Co-authored-by: Andrea Amorosi <dreamorosi@gmail.com> * Update packages/logger/tests/unit/Logger.test.ts Co-authored-by: Andrea Amorosi <dreamorosi@gmail.com> * docs: added single command for local setup in contribuiting * chore: fixed propriety typo Co-authored-by: Andrea Amorosi <dreamorosi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds the option of removing persistent keys from a logger instance.
Developers are now able to do it using the method
removeKeys. The method accepts as parameter an array of keys to be removed.How to verify this change
Unit tests & E2E tests added and passing locally.
Related issues, RFCs
#482
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.