Replace reqwest with hyper client #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the size the of the final binary by 2.5MB. Signed-off-by: David Calavera <david.calavera@gmail.com>
bnusunny
approved these changes
Jan 7, 2023
|
|
||
| let (text, _, _) = encoding.decode(&body); | ||
| match text { | ||
| Cow::Owned(s) => Ok(LambdaBody::Text(s)), |
There was a problem hiding this comment.
Clion complains that 's' is a "str", not "String". However, this code compiles with no issue. I'm a bit puzzled by this. It could be a bug in Clion Rust plugin.
There was a problem hiding this comment.
CLion gives the same message for Reqwest. This is indeed an issue with CLion Rust plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the size the of the final binary by 2.5MB. In the great scheme of things, 2.5MB is not much, but Lambda zip deploys have a combined hard limit of 250MB to fit the function's code and all the layers. Making this extension smaller means that there is a little bit more room for other things in the deploy.
The new code is completely equivalent to what reqwest was doing, without the additional layer of indirection and extra code.
Original size:
Size after these changes:
Signed-off-by: David Calavera david.calavera@gmail.com
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
@ferdingler