refactor: track upstream telemetry changes #1068
Conversation
| { | ||
| "id": "e965338d-28c5-41e2-b585-121d9d56393f", | ||
| "type": "misc", | ||
| "description": "**BREAKING**: Remove `smithy.client.request.size`, `smithy.client.response.size`, `smithy.client.retires` metrics. Rename all `smithy.client.*` metrics to `smithy.client.call.*`." |
There was a problem hiding this comment.
this description seems inaccurate
There was a problem hiding this comment.
How so?
One of the things I've been thinking about is that a lot of user facing features/information is lost in generic "update smithy-kotlin to x.y.z". I deliberately made this the same as smithy-kotlin since otherwise it's not useful as a changelog entry really.
Curious what others think.
There was a problem hiding this comment.
deliberately made this the same as
smithy-kotlin
Ok, I thought this was just a copy-paste error. This makes sense then.
I think we had this discussion before and decided to not include each smithy-kotlin change in aws-sdk-kotlin changelog entry because it should be treated as just another 3P dependency, but it makes sense for changes like this.
aajtodd
force-pushed
the
refactor-telemetry
branch
from
02c9abb to
c6f146f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
A new generated diff is ready to view.
|
Issue #
upstream: smithy-lang/smithy-kotlin#973
Description of changes
aws.request_id2attribute toaws.extended_request_idBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.