fix: apply clock skew interceptor to clients created via invoke
#1284
Conversation
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
ianbotsf
added
the
acknowledge-api-break
|
FYI I added the ackhowledge-api-break label to this PR because I think the breaks are safe but please chime in if you have differing opinions. |
| @@ -23,18 +23,14 @@ class ServiceClientCompanionObjectWriterTest { | |||
| ServiceClientCompanionObjectWriter().write(writer, null) | |||
|
|
|||
| val expected = """ | |||
| public companion object : AbstractAwsSdkClientFactory<Config, Config.Builder, TestGeneratorClient, Builder>() { | |||
There was a problem hiding this comment.
This is a test for the companion object but there's no longer a companion object being generated, is that because there's no protocol? Can we add a protocol or maybe rename the test?
There was a problem hiding this comment.
It's no longer ServiceClientCompanionObjectWriter's job to create the companion object, merely to append things to sections of it, which the updated test reflects. In my view the class and test names are still correct.
|
|
Discussed offline and this change is breaking enough that we don't want to push it directly to main. Updated base branch to v1.2. Will pursue a temporary fix strictly within aws-sdk-kotlin codegen until such time as we have another minor version bump. |
* fix: apply clock skew interceptor to clients created via `invoke` (#1284) * Add new changelog * Upgrade Kotlin version to match smithy-kotlin --------- Co-authored-by: Ian Botsford <83236726+ianbotsf@users.noreply.github.com>
Issue #
Addresses #1211
Description of changes
This change adds the clock skew interceptor to clients created via
invoke(as opposed tofromEnvironment). It pulls in upstream changes from smithy-kotlin which add afinalizeConfigmethod to the abstract superclass from whichAbstractAwsSdkClientFactoryextends. This causes a naming conflict so the SDK'ssuspendfinalizeConfigmethod has been renamedfinalizeEnvironmentalConfig.Companion PR: smithy-lang/smithy-kotlin#1067
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.