add attribute converters for "standard" values #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions of the word "standard")
|
A new generated diff is ready to view.
|
lauzadis
reviewed
Aug 7, 2024
...mapper/dynamodb-mapper/common/src/aws/sdk/kotlin/hll/dynamodbmapper/values/ValueConverter.kt
Outdated
Show resolved
Hide resolved
...amodb-mapper/common/src/aws/sdk/kotlin/hll/dynamodbmapper/values/collections/MapConverter.kt
Outdated
Show resolved
Hide resolved
...mapper/common/src/aws/sdk/kotlin/hll/dynamodbmapper/values/collections/StringSetConverter.kt
Outdated
Show resolved
Hide resolved
...amodb-mapper/common/src/aws/sdk/kotlin/hll/dynamodbmapper/values/scalars/NumberConverters.kt
Outdated
Show resolved
Hide resolved
.../dynamodb-mapper/common/test/aws/sdk/kotlin/hll/dynamodbmapper/values/ValueConvertersTest.kt
Outdated
Show resolved
Hide resolved
ianbotsf
commented
Aug 8, 2024
...mapper/dynamodb-mapper/common/src/aws/sdk/kotlin/hll/dynamodbmapper/values/ValueConverter.kt
Outdated
Show resolved
Hide resolved
...amodb-mapper/common/src/aws/sdk/kotlin/hll/dynamodbmapper/values/collections/MapConverter.kt
Outdated
Show resolved
Hide resolved
...mapper/common/src/aws/sdk/kotlin/hll/dynamodbmapper/values/collections/StringSetConverter.kt
Outdated
Show resolved
Hide resolved
...amodb-mapper/common/src/aws/sdk/kotlin/hll/dynamodbmapper/values/scalars/NumberConverters.kt
Outdated
Show resolved
Hide resolved
.../dynamodb-mapper/common/test/aws/sdk/kotlin/hll/dynamodbmapper/values/ValueConvertersTest.kt
Outdated
Show resolved
Hide resolved
...er/common/src/aws/sdk/kotlin/hll/dynamodbmapper/values/smithytypes/DocumentValueConverter.kt
Outdated
Show resolved
Hide resolved
+ `fromAv`/`toAv` → `fromAttributeValue`→`toAttributeValue` + Commonizing string/char/chararray converters + Update number parsing to use non-nullable lambda types + Miscellaneous fixes and naming tweaks
|
A new generated diff is ready to view.
|
0marperez
approved these changes
Aug 9, 2024
lauzadis
approved these changes
Aug 26, 2024
| * Converts between potentially `null` values and | ||
| * [DynamoDB `NULL` values](https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/HowItWorks.NamingRulesDataTypes.html#HowItWorks.DataTypes.Null). | ||
| * Note that this class is a [SplittingConverter] and the logic for handling non-null values is undefined in this class. | ||
| * Thus, it is typically used in conjunction with |
| * Creates a [ValueConverter] which converts between number type [N] and | ||
| * [DynamoDB `N` values](https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/HowItWorks.NamingRulesDataTypes.html#HowItWorks.DataTypes.Number) | ||
| */ | ||
| public fun <N> numberConverter(numberToStringConverter: Converter<N, String>): ValueConverter<N> = |
There was a problem hiding this comment.
Should we capitalize this function name to match others?
There was a problem hiding this comment.
Yes, I was inconsistent here.
There was a problem hiding this comment.
nit: add metadata like description, module name
settings.gradle.kts
Outdated
Comment on lines
20
to
22
| plugins { | ||
| id("org.gradle.toolchains.foojay-resolver-convention") version "0.8.0" | ||
| } |
There was a problem hiding this comment.
Whoops, that's an unintentional addition (I was using it on another branch for some debug). Removing!
…in KDocs, remove frivolous dependencies, add module metadata just like I asked of others
|
ianbotsf
added a commit
that referenced
this pull request
Oct 29, 2024
…lin (#1451) * initial poc commit of DynamoDB Mapper (#1232) * add support for Mapper initialization (#1237) * implement mapper pipeline (#1266) * initial implementation of codegen for low-level operations/types (#1357) * initial implementation of secondary index support (#1375) * Create new codegen module and refactor annotation processor to use it (#1382) * feat: add Schema generator Gradle plugin (#1385) * Fix plugin test package * add attribute converters for "standard" values (#1381) * fix: schema generator plugin test module (#1394) * feat: annotation processor codegen configuration (#1392) * feat: add `@DynamoDbIgnore` annotation (#1402) * DDB Mapper filter expressions (runtime components) (#1401) * feat: basic annotation processing (#1399) * add DSL overloads, paginators, and better builder integration for DDB Mapper ops codegen (#1409) * chore: split dynamodb-mapper-codegen into two modules (#1414) * emit DDB_MAPPER business metric (#1426) * feat: setup DynamoDbMapper publication (#1419) * DDB Mapper filter expressions (codegen components) (#1424) * correct docs * mark every HLL/DDBM API experimental (#1428) * fix accidental inclusion of expression attribute members in high-level DynamoDB Mapper requests (#1432) * Upgrade to latest build plugin version * fix: various issues found during testing (#1450) * chore: update Athena changelog notes for 1.3.57 (2024-10-18) release (#1449) * feat: update AWS API models * feat: update AWS service endpoints metadata * chore: release 1.3.60 * chore: bump snapshot version to 1.3.61-SNAPSHOT * feat: initial release of Developer Preview of DynamoDB Mapper for Kotlin * Fix Kotlin gradle-plugin version * fix: ddb mapper tests (#1453) * Bump build plugin version --------- Co-authored-by: Matas <lauzmata@amazon.com> Co-authored-by: aws-sdk-kotlin-ci <aws-kotlin-sdk-automation@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Related to #472
Description of changes
This change fills out new
ValueConverterimplementations for "standard" types (using a somewhat arbitrary definition of the word "standard"). Specifically they include:String,Int,Boolean, etc.List,Map, andSetUrl,Document, andInstantI also introduced a
ValueConvertersTestclass to streamline unit testing with a DSL. I'll be interested to hear feedback on whether this is effective or if it just obscures things.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.