misc: add rules engine codegen tests #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0marperez
added
the
no-changelog
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
This comment has been minimized.
This comment has been minimized.
lauzadis
approved these changes
Nov 6, 2024
settings.gradle.kts
Outdated
| @@ -53,6 +53,7 @@ include(":hll:hll-mapping-core") | |||
| include(":services") | |||
| include(":tests") | |||
| include(":tests:codegen:event-stream") | |||
| include("tests:codegen:rules-engine") | |||
There was a problem hiding this comment.
correctness: missing leading colon :tests:codegen:rules-engine
| // doing it this way (as opposed to doing what we do for protocol-tests) allows | ||
| // the tests to work without a publish to maven-local step at the cost of maintaining | ||
| // this set of dependencies manually | ||
| // <-- BEGIN GENERATED DEPENDENCY LIST --> |
There was a problem hiding this comment.
What is this dependency list generated by?
There was a problem hiding this comment.
I think it's just manually written. I couldn't find anything that suggests it's code generated
There was a problem hiding this comment.
I noticed most of this file is copy-pasted from elsewhere, is there any reason this needs to be a new module rather than in the existing codegen tests?
There was a problem hiding this comment.
Organization mostly, it didn't feel right to have this under tests/codegen/event-stream
There was a problem hiding this comment.
I'd rather see the codegen build scripts abstracted to cover both event streams and endpoint rules than copy-pasting the entire file, is that possible?
|
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
ianbotsf
approved these changes
Dec 13, 2024
… jmespath-flatten
0marperez
force-pushed
the
jmespath-flatten
branch
from
7d8d115 to
d3279aa
Compare
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
0marperez
added
the
acknowledge-artifact-size-increase
This comment has been minimized.
This comment has been minimized.
|
|
A new generated diff is ready to view.
|
Affected ArtifactsSignificantly increased in size
Changed in size
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.