Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default value protocol tests do not pass #1330

Closed
2 tasks
jbelkins opened this issue Feb 8, 2024 · 0 comments
Closed
2 tasks

Default value protocol tests do not pass #1330

jbelkins opened this issue Feb 8, 2024 · 0 comments
Assignees
@sichanyoo
Labels
area/protocol-tests Relates to protocol tests feature-request A feature should be added or improved.

Comments

@jbelkins
Copy link
Contributor

jbelkins commented Feb 8, 2024

Describe the feature

There are several protocol tests related to default values which are currently disabled. These tests are tagged with defaults; that tag is currently disabled in every AWS protocol.

Make the changes needed to pass these tests and re-enable them for all protocols.

Use Case

To ensure that SDK behavior is as required by the Smithy protocol test suite.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@jbelkins jbelkins added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. area/protocol-tests Relates to protocol tests and removed needs-triage This issue or PR still needs to be triaged. labels Feb 8, 2024
@jbelkins jbelkins added this to the GA milestone Feb 12, 2024
@smivij smivij removed this from the GA milestone Aug 2, 2024
@sichanyoo sichanyoo self-assigned this Aug 21, 2024
This was referenced Aug 28, 2024
Merged
Merged
@jbelkins jbelkins closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sichanyoo sichanyoo

Labels
area/protocol-tests Relates to protocol tests feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbelkins @sichanyoo @smivij