Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add default trait support #1696

Merged
merged 7 commits into from
Sep 6, 2024
Merged

feat: Add default trait support #1696

merged 7 commits into from
Sep 6, 2024

Conversation

sichanyoo
Copy link
Contributor

@sichanyoo sichanyoo commented Aug 28, 2024 •
edited
Loading

Issue #

Description of changes

  • Remove x-amz-content-sha256 header logic from Sha256TreeHashMiddleware as it cannot be set before CRT signer
  • Re-enable 8 protocol tests tagged with defaults that used to be disabled
// Re-enabled protocol tests for restJson1 with defaults tag
testRestJsonClientPopulatesDefaultValuesInInput
testRestJsonClientPopulatesNestedDefaultValuesWhenMissing
testRestJsonClientPopulatesDefaultsValuesWhenMissingInResponse

// Re-enabled protocol tests for awsJson10 with defaults tag
testAwsJson10ClientPopulatesDefaultValuesInInput
testAwsJson10ClientPopulatesNestedDefaultValuesWhenMissing
testAwsJson10ClientPopulatesDefaultsValuesWhenMissingInResponse
testAwsJson10ClientErrorCorrectsWhenServerFailsToSerializeRequiredValues

Note: testRestJsonClientIgnoresDefaultValuesIfMemberValuesArePresentInResponse test is kept disabled because the underlying Smithy test case is wrong and the fix will be released with v1.51.0.

New/existing dependencies impact assessment, if applicable

Conventional Commits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

dayaffe
dayaffe reviewed Aug 29, 2024
View reviewed changes
...es/Core/AWSClientRuntime/Sources/AWSClientRuntime/Middlewares/Sha256TreeHashMiddleware.swift Outdated
@@ -25,13 +25,7 @@ public struct Sha256TreeHashMiddleware<OperationStackInput, OperationStackOutput
) async throws {
switch request.body {
case .data(let data):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got some warning messages in here we should take care of

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed warnings

jbelkins
jbelkins reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@jbelkins jbelkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question

Sources/Core/AWSClientRuntime/Sources/AWSClientRuntime/UserAgent/BusinessMetrics.swift Show resolved Hide resolved
...software/amazon/smithy/aws/swift/codegen/protocols/restjson/AWSRestJson1ProtocolGenerator.kt Show resolved Hide resolved
...es/Core/AWSClientRuntime/Sources/AWSClientRuntime/Middlewares/Sha256TreeHashMiddleware.swift Show resolved Hide resolved
@sichanyoo sichanyoo mentioned this pull request Sep 3, 2024
Closed
@jbelkins jbelkins self-requested a review September 3, 2024 21:13
@sichanyoo sichanyoo merged commit aacff71 into main Sep 6, 2024
30 checks passed
@sichanyoo sichanyoo deleted the feat/default-trait-support branch September 6, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dayaffe dayaffe dayaffe approved these changes

@jbelkins jbelkins jbelkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sichanyoo @jbelkins @dayaffe