Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable a broken protocol test when fix is released in Smithy v1.51.0 #1706

Closed
sichanyoo opened this issue Sep 3, 2024 · 2 comments
Closed
Assignees

Comments

@sichanyoo
Copy link
Contributor

Background

Smithy's protocol test definition for RestJsonClientIgnoresDefaultValuesIfMemberValuesArePresentInResponse had an error in the expected value which was fixed here, but this won't be available until a new release of v1.51.0 that contains the fix is available.

For now this protocol test will stay disabled even after default value support work get merged (smithy-swift PR, aws-sdk-swift PR).

Enable the test once Smithy releases v1.51.0 and we start using that version.

@sichanyoo sichanyoo changed the title Enable RestJsonClientIgnoresDefaultValuesIfMemberValuesArePresentInResponse protocol test when Smithy v1.51.0 is released Enable a broken protocol test when Smithy v1.51.0 is released Sep 3, 2024
@sichanyoo sichanyoo changed the title Enable a broken protocol test when Smithy v1.51.0 is released Enable a broken protocol test when fix is released in Smithy v1.51.0 Sep 3, 2024
@sichanyoo sichanyoo added the needs-triage This issue or PR still needs to be triaged. label Sep 3, 2024
@jbelkins
Copy link
Contributor

jbelkins commented Sep 4, 2024

Blocked while waiting for the next Smithy release.

@jbelkins jbelkins removed the needs-triage This issue or PR still needs to be triaged. label Sep 4, 2024
@jbelkins
Copy link
Contributor

Smithy 1.51 release is complete. Moving back to Todo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants