Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Address strict concurrency warnings #1567

Merged
merged 11 commits into from
Jul 5, 2024

Conversation

sichanyoo
Copy link
Contributor

@sichanyoo sichanyoo commented Jun 13, 2024

Issue #

#1414

Description of changes

Address strict concurrency warnings thrown by building with

swift build --build-tests -Xswiftc -strict-concurrency=complete

This PR addresses warnings that will become compile errors in Swift 6.

Changes fall under one of the following:

  • Adding conformance to Sendable protocol
  • Adding @preconcurrency tag to C library import
  • Changing global variable into a static function that returns that value

New/existing dependencies impact assessment, if applicable

Conventional Commits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sichanyoo sichanyoo merged commit 73d2747 into main Jul 5, 2024
29 checks passed
@sichanyoo sichanyoo deleted the chore/strict-concurrency-check branch July 5, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants