Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove dependency on AWSSDKIdentity unless necessary #1650

Merged
merged 4 commits into from
Jul 26, 2024

Conversation

sichanyoo
Copy link
Contributor

@sichanyoo sichanyoo commented Jul 26, 2024

Companion PR: smithy-lang/smithy-swift#789

Issue #

Description of changes

  • Use resolver chain for bearer token only if service actually uses HTTP bearer auth. For services that do not use bearer auth, use static token resolver instead, which is part of SmithyIdentity module.
  • This allows removal of unnecessary dependency on AWSSDKIdentity.
  • Also, make DefaultBearerTokenIdentityResolverChain be imported as struct

New/existing dependencies impact assessment, if applicable

Conventional Commits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sichanyoo sichanyoo requested a review from jbelkins July 26, 2024 17:50
@sichanyoo sichanyoo changed the title chore: Remove unneeded dependency on AWSSDKIdentity chore: Remove dependency on AWSSDKIdentity unless necessary Jul 26, 2024
Copy link
Contributor

@jbelkins jbelkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I code generate with this branch, every service still has a AWSSDKIdentity.DefaultBearerTokenIdentityResolverChain. Do you see the same?

(also, a nit: modify the DefaultBearerTokenIdentityResolverChain symbol so that it imports as a struct.)

Copy link
Contributor

@jbelkins jbelkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending green build. Re-perform codegen in separate PR after merge.

@sichanyoo sichanyoo merged commit 1e58b27 into main Jul 26, 2024
29 checks passed
@sichanyoo sichanyoo deleted the chore/clean-unneeded-dependency branch July 26, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants