Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add regex validation for session name to relevant resolvers #1700

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

sichanyoo
Copy link
Contributor

Issue #

Description of changes

  • Add regex validation for session name to STSAssumeRole and STSWebIdentity credential resolver initializers so that error gets caught and thrown wayyyy before it does without this change (i.e., bad request exception returned from STS server)

New/existing dependencies impact assessment, if applicable

Conventional Commits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@jbelkins jbelkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment, you're actually using Objective-C regex support.

Also fix the swiftlint warning

Copy link
Contributor

@jbelkins jbelkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing docs, Swift regex support requires macOS platform support above our minimum version.

Approving with Foundation regex support as written.

@sichanyoo sichanyoo merged commit a92aee4 into main Sep 3, 2024
29 checks passed
@sichanyoo sichanyoo deleted the chore/session-name-validation branch September 3, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants