-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add unauthenticated API integration test #1703
Conversation
_ = try await cognitoIdentityClient.getId( | ||
input: GetIdInput(accountId: accountID, identityPoolId: identityPoolID) | ||
) | ||
// API call completed successfully |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we check that the deserialized response contains expected results?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, though reaching line 49 would mean the operation succeeded without throwing error, it wouldn't hurt to check it. Adopting suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point of this is to prove that unauthenticated requests can be performed successfully. But the machine performing integration tests will have a set of AWS credentials configured for use in all the other tests.
How do we show that this request was generated unauthenticated, and isn't just succeeding because there happen to be credentials on the machine?
We know for sure that the operation used in this new integration test doesn't use authentication and is sending an unauthenticated request because the generated auth scheme resolver for This means when the auth scheme gets resolved during runtime, it resolves as a "no-auth" auth scheme in Edit: Added sanity-check for checking that request is indeed unauthenticated using an interceptor, after offline discussion. |
…labs/aws-sdk-swift into chore/unauthenticated-api-integ-test
A check was added to the test to ensure that the HTTP |
Issue #
Description of changes
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.