Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Test code-generated Waiters components #732

Merged
merged 23 commits into from
Dec 16, 2022
Merged

feat: Test code-generated Waiters components #732

merged 23 commits into from
Dec 16, 2022

Conversation

jbelkins
Copy link
Contributor

@jbelkins jbelkins commented Dec 1, 2022 •
edited
Loading

Issue #

Part of smithy-lang/smithy-swift#448
Fixes #733

Description of changes

Provides a Smithy definition of a service/operation with a waiter, code-generates it in conjunction with protocol tests, and tests the code-generated waiter to verify that its logic behaves as expected.

Also includes a couple of handy scripts for use during codegen development.

New/existing dependencies impact assessment, if applicable

No new dependencies were added to this change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

epau
epau reviewed Dec 1, 2022
View reviewed changes
scripts/regen.sh Outdated Show resolved Hide resolved
@jbelkins jbelkins mentioned this pull request Dec 2, 2022
Merged
2 tasks
jbelkins
jbelkins commented Dec 2, 2022
View reviewed changes
Package.swift Outdated Show resolved Hide resolved
jbelkins
jbelkins commented Dec 2, 2022
View reviewed changes
packageDependencies.plist Outdated Show resolved Hide resolved
@jbelkins jbelkins requested a review from epau December 2, 2022 20:51
@jbelkins jbelkins marked this pull request as ready for review December 2, 2022 21:48
@jbelkins jbelkins changed the base branch from main to feat/waiters December 8, 2022 22:59
epau
epau approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@epau epau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Just revert the clientRuntimeBranch back to main then merge

@jbelkins
Copy link
Contributor Author

@epau Pointed smithy-swift to feat/waiters instead of main since the corresponding smithy-swift work merges there first.

Once there are green builds on feat/waiters on both repos, we can merge those each to main (after changing the smithy-swift branch to main.)

@jbelkins jbelkins merged commit 247dba8 into feat/waiters Dec 16, 2022
@jbelkins jbelkins deleted the jbe/acceptors branch December 16, 2022 21:04
jbelkins added a commit that referenced this pull request Dec 19, 2022
@jbelkins
feat: Smithy Waiters (#755)
2ba6da4 
* feat: Add WaiterTypedError compliance to UnknownAWSHttpServiceError (#754)
* feat: Test code-generated Waiters components (#732)
* fix: Add waiters generated test for AND and for number equality & inequality (#762)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epau epau epau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbelkins @epau