Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add waiters generated test for AND and for number equality & inequality #760

Closed
wants to merge 1 commit into from

Conversation

jbelkins
Copy link
Contributor

Description of changes

Adds a generated waiter that uses an AND expression plus number equality & inequality. Provides test coverage for issues in smithy-swift PRs:
smithy-lang/smithy-swift#493
smithy-lang/smithy-swift#494

New/existing dependencies impact assessment, if applicable

No new dependencies were added to this change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jbelkins jbelkins requested a review from epau December 17, 2022 19:28
@jbelkins jbelkins marked this pull request as ready for review December 17, 2022 19:28
@jbelkins
Copy link
Contributor Author

Closing & reopening with branch name jbe/jmes_comparison_fixes so it builds on CI with the branch of the same name on smithy-swift.

@jbelkins jbelkins closed this Dec 18, 2022
@jbelkins jbelkins deleted the jbe/more_generated_waiters_tests branch June 24, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant