Skip to content

Commit

Permalink
feat(aws-eventbridge-sns , aws-events-rule-sns, aws-events-rule-lambd…
Browse files Browse the repository at this point in the history
…a): custom event bus support (#362)

* enhanced construct to support custom EventBus

* fix linting issues

* fix PR review comments

* refactoring and use IEventBus instead of EventBus

* added support for custom event bus

* update the props naming convention to align with existing constructs

* updated the props documentation

* updated props naming convention

* enhance aws-events-rule-lambda to support custom eventbus

* refactoring & enhanced aws-events-rule-sns to support custom eventbus

* update viperlight to fix the test

* Address PR comments

Co-authored-by: santhosh <>
  • Loading branch information
surukonda authored Sep 3, 2021
1 parent 9b985fc commit 47221d9
Show file tree
Hide file tree
Showing 29 changed files with 4,648 additions and 119 deletions.
4 changes: 2 additions & 2 deletions .viperlightignore
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ source/patterns/@aws-solutions-constructs/aws-lambda-sqs-lambda/test/lambda-sqs-
source/patterns/@aws-solutions-constructs/aws-lambda-sqs-lambda/test/lambda-sqs-lambda.test.ts:67
source/patterns/@aws-solutions-constructs/aws-lambda-step-function/test/lambda-step-function.test.ts:130
source/patterns/@aws-solutions-constructs/aws-lambda-stepfunctions/test/lambda-stepfunctions.test.ts:130
source/patterns/@aws-solutions-constructs/aws-events-rule-sns/test/events-rule-sns-topic.test.ts:243
source/patterns/@aws-solutions-constructs/aws-eventbridge-sns/test/eventbridge-sns-topic.test.ts:243
source/patterns/@aws-solutions-constructs/aws-events-rule-sns/test/events-rule-sns-topic.test.ts:255
source/patterns/@aws-solutions-constructs/aws-eventbridge-sns/test/eventbridge-sns-topic.test.ts:255
source/patterns/@aws-solutions-constructs/aws-events-rule-sqs/test/events-rule-sqs-queue.test.ts:131
source/patterns/@aws-solutions-constructs/aws-eventbridge-sqs/test/eventbridge-sqs-queue.test.ts:131
source/patterns/@aws-solutions-constructs/aws-dynamodb-stream-lambda/test/dynamodb-stream-lambda.test.ts:105
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,31 +28,31 @@ export interface EventbridgeToLambdaProps {
*
* @default - None
*/
readonly existingLambdaObj?: lambda.Function,
readonly existingLambdaObj?: lambda.Function;
/**
* User provided props to override the default props for the Lambda function.
*
* @default - Default props are used
*/
readonly lambdaFunctionProps?: lambda.FunctionProps,
readonly lambdaFunctionProps?: lambda.FunctionProps;
/**
* Existing instance of a custom EventBus.
*
* @default - None
*/
readonly existingEventBusInterface?: events.IEventBus,
readonly existingEventBusInterface?: events.IEventBus;
/**
* A new custom EventBus is created with provided props.
*
* @default - None
*/
readonly eventBusProps?: events.EventBusProps,
readonly eventBusProps?: events.EventBusProps;
/**
* User provided eventRuleProps to override the defaults
*
* @default - None
*/
readonly eventRuleProps: events.RuleProps
readonly eventRuleProps: events.RuleProps;
}

export class EventbridgeToLambda extends Construct {
Expand Down
Loading

0 comments on commit 47221d9

Please sign in to comment.