Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (Disable Data trace logging as default in API Gateway constructs) #218

Closed
1 of 2 tasks
biffgaut opened this issue Jun 9, 2021 · 0 comments · Fixed by #222
Closed
1 of 2 tasks

feat (Disable Data trace logging as default in API Gateway constructs) #218

biffgaut opened this issue Jun 9, 2021 · 0 comments · Fixed by #222
Assignees
@biffgaut
Labels
feature-request A feature should be added or improved in-progress This issue is being actively worked on

Comments

@biffgaut
Copy link
Contributor

biffgaut commented Jun 9, 2021

Disable Data trace logging in the default settings for API Gateway in constructs where this service appears.

Use Case

AWS Security best practice for production.

Proposed Solution

Explicitly set the value in the default properties.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@biffgaut biffgaut added feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged in-progress This issue is being actively worked on and removed needs-triage The issue or PR still needs to be triaged labels Jun 9, 2021
@biffgaut biffgaut self-assigned this Jun 9, 2021
@biffgaut biffgaut mentioned this issue Jun 11, 2021
Merged
@biffgaut biffgaut linked a pull request Jun 11, 2021 that will close this issue
feat (Disable DataTraceEnabled by default in API Gateway constructs #222
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@biffgaut biffgaut

Labels
feature-request A feature should be added or improved in-progress This issue is being actively worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat (Disable DataTraceEnabled by default in API Gateway constructs awslabs/aws-solutions-constructs
1 participant
@biffgaut