Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (Disable DataTraceEnabled by default in API Gateway constructs #222

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

biffgaut
Copy link
Contributor

Issue #, if available:
218

Description of changes:
Set DataTraceEnabled to false by default in all API Gateway constructs. This is best practice according to AWS Security

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@biffgaut biffgaut requested a review from hnishar as a code owner June 11, 2021 21:21
@biffgaut biffgaut linked an issue Jun 11, 2021 that may be closed by this pull request
2 tasks
@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: codebuildgithubautobuildPro-fkVQbXRiQi6A
  • Commit ID: bcac515
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@biffgaut biffgaut merged commit 3e346ac into main Jun 14, 2021
@biffgaut biffgaut deleted the Issue218 branch June 14, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat (Disable Data trace logging as default in API Gateway constructs)
3 participants