feat(aws-s3-stepfunctions): added logS3AccessLogs and S3BucketInterface #500
Conversation
mickychetta
requested review from
biffgaut,
hayesry and
hnishar
as code owners
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -32,7 +34,16 @@ const props: S3ToStepfunctionsProps = { | |||
| logGroupProps: { | |||
| removalPolicy: RemovalPolicy.DESTROY | |||
| }, | |||
| logS3AccessLogs: false, | |||
| deployCloudTrail: false | |||
There was a problem hiding this comment.
If we left this set to true (or default) on one test, I'm guessing it leaves behind a bucket?
There was a problem hiding this comment.
Yes, that is correct
There was a problem hiding this comment.
Do we have a unit test that sets deployCloudTrail to true so we test it somewhere?
There was a problem hiding this comment.
No, I turned it off so it doesn't leave any CloudTrail logging buckets for all tests. Did you want me to leave it on for a test?
Issue #485 , if available:
Description of changes:
-Added logS3AccessLogs construct prop and s3BucketInterface
-Updated README with new props
-Updated integ tests with no logging bucket
-Improve tests for 100% coverage, deleted repetitive conditions that were covered in input-validation.ts
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.