Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-s3-sns): created new construct #849
feat(aws-s3-sns): created new construct #849
Changes from 1 commit
51db29c
ee52701
adf993d
70e8994
fa4eb4b
6ee16f9
69c6ba3
6a14de7
47a9399
b7aecd0
073b35b
b4b7c4a
a16048c
2a08f10
f0a0745
0288b6b
bace851
3ffe4b1
d330ada
7048e3f
1f6d9bc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just using
if (props.enableEncryptionWithCustomerManagedKey !== false)
directly in the code achieves the same result without hiding the meaning within another variable. Could even:
if (props.enableEncryptionWithCustomerManagedKey !== false) // default to true
for clarity
(quick code snippet from Typescript Playground for proof:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait - all we do is pass this to an optional prop attribute on BuildTopicProps? Why not just handle this default inside of BuildTopicProps? That ensures consistent behavior across constructs better than code reviews that check if each construct is using the correct default value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do on the simplified if logic.
Regarding the default value- I'd love to do that, but, unfortunately the sns-helper defaults the value to False, which is not overridden in other constructs, so we would be changing the behavior there as well. Specifically, the following constructs keep the default as False -
aws-fargate-sns
,aws-lambda-sns
,aws-sns-lambda
.Let me know how you would prefer to proceed, leaving it alone, or updating it as described. If updating the default to True, which will use a CMK results in a better security posture anyway, then maybe we should do it for both consistency and security's sake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really hate how dependent we are becoming on this paradigm of returning an array of anonymous values (there's a lot more of this in firehose-s3).
I think we need to start considering defining an interface for return values from our build* functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I love that idea too. I'd prefer to keep this PR for the new construct and then do that refactor as a quick follow-up. I've created #853 to track it.