Move AWS distro tutorials to distributions/aws directory #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajkota
force-pushed
the
v1.3-readme-update
branch
2 times, most recently
from
10d7d54
to
11bf83a
Compare
surajkota
force-pushed
the
v1.3-readme-update
branch
from
11bf83a
to
c48e853
Compare
ryansteakley
reviewed
Dec 9, 2021
| @@ -33,7 +33,7 @@ This guide assumes that you have: | |||
| ``` | |||
| 1. AWS IAM permissions to create roles and attach policies to roles. | |||
|
|
|||
| 1. Clone the `awslabs/kubeflow-manifest` repo. | |||
| 1. Clone the `awslabs/kubeflow-manifest` repo and checkout release branch. | |||
There was a problem hiding this comment.
nit: Calling it out as release branch here as of right now it doesn't currently exist? Also how will we handle the different versions i.e (1.3 ... 1.4)? maybe state desired release branch?
There was a problem hiding this comment.
the branch we are working on are release branches, e.g. v1.3-branch but this will be changed when we get closer to release since we will cut a tag
ryansteakley
reviewed
Dec 9, 2021
ryansteakley
approved these changes
Dec 9, 2021
surajkota
force-pushed
the
v1.3-readme-update
branch
from
c48e853
to
91cffdf
Compare
goswamig
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Testing
Manual, WIP
Checked login, ran a sample pipeline to verify rds and s3 connections and verified a notebook server default options have DLC image
#26