Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flags for KCM in 1.22 version #271

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Conversation

prateekgogia
Copy link
Member

Issue #, if available:

Description of changes:

Fixes couple of broken flags in KCM for 1.22 version for guest clusters.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hakuna-matatah
Copy link
Contributor

hakuna-matatah commented Aug 17, 2022

Haha, these functions will be more and more as we support older versions of K8s as new versions get released upstream. Unfortunately we are stuck with this currently but I encourage us to move in the direction of cutting release branches like upstream and not support these kind of functions in Head, if possible.

@prateekgogia
Copy link
Member Author

Haha, these functions will be more and more as we support older versions of K8s as new versions get released upstream. Unfortunately we are stuck with this currently but I encourage us to move in the direction of cutting release branches like upstream and not support these kind of functions in Head, if possible.

How will that look when we want to create different Kubernetes versions? As these will be different binaries for operator based on Kubernetes versions.

@prateekgogia prateekgogia merged commit 9380755 into awslabs:main Aug 17, 2022
@prateekgogia prateekgogia deleted the sec-patch branch August 17, 2022 19:56
@hakuna-matatah
Copy link
Contributor

Haha, these functions will be more and more as we support older versions of K8s as new versions get released upstream. Unfortunately we are stuck with this currently but I encourage us to move in the direction of cutting release branches like upstream and not support these kind of functions in Head, if possible.

How will that look when we want to create different Kubernetes versions? As these will be different binaries for operator based on Kubernetes versions.

Well I was saying same binary for upstream supported versions of k8s and not having to maintain same binary for non-supported upstream versions of K8s, so that if someone wants to test something on older versions they can surely do so by building/downloading that release binary and do the testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants