Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for 1.25 #361

Merged
merged 1 commit into from
Feb 10, 2023
Merged

add support for 1.25 #361

merged 1 commit into from
Feb 10, 2023

Conversation

ivelichkovich
Copy link

Issue #, if available:

Description of changes:

Adding support for 1.25

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hakuna-matatah
Copy link
Contributor

Nice, have you tested this change out by spinning a 1.25 ? Want to make sure images are published and accessible etc.

@ivelichkovich
Copy link
Author

Yup they are tested

NAME                                 READY   STATUS    RESTARTS   AGE
example-apiserver-54df67bf8b-k9skl   1/1     Running   0          157m
example-authenticator-f8ff9          1/1     Running   0          157m
example-controller-manager-8bp6c     1/1     Running   0          157m
example-etcd-0                       1/1     Running   0          168m
example-etcd-1                       1/1     Running   0          168m
example-etcd-2                       1/1     Running   0          168m
example-scheduler-clqt7              1/1     Running   0          157m

@hakuna-matatah

Copy link
Member

@prateekgogia prateekgogia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, rest LGTM!

@@ -51,6 +51,7 @@ apply: ## Apply the controller into your ~/.kube/config cluster
$(HELM_OPTS) \
--set controller.image=ko://github.com/awslabs/kubernetes-iteration-toolkit/operator/cmd/controller \
--set webhook.image=ko://github.com/awslabs/kubernetes-iteration-toolkit/operator/cmd/webhook \
--set serviceAccount.create=true \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens if SA already exists in the cluster and someone runs make apply?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will work if it already exists and was created by the helm chart. If it was manually created though then helm will have a conflict with it.

Copy link
Member

@prateekgogia prateekgogia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prateekgogia prateekgogia merged commit 881918a into awslabs:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants