Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: parse error during stack diff #598

Closed
wants to merge 1 commit into from

Conversation

k7k0
Copy link
Contributor

@k7k0 k7k0 commented Oct 8, 2024

Fix #597

Bug introduced during upgrade to CDK to 2.148 mangleLikeCloudFormation and fullDiff requires the template content in JSON format instead of the file paths.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@erwaxler
Copy link
Contributor

Hi @k7k0 , thank you for your contribution to the Landing Zone Accelerator!

I'm pleased to say this work has been integrated into the code base and will be available shortly in the v1.10.0 release. I'll close this PR in the meantime and update the associated issue once that release is publicly available.

Thank you for your support of the LZA!

@erwaxler erwaxler closed this Oct 11, 2024
@richardkeit
Copy link
Contributor

Too good @k7k0 and @erwaxler

Appreciate it 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON parse error inprintStackDiff leading to malformed diffs
3 participants