fix: get-accelerator-metadata getLastSuccessfulPipelineExecution
#623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @StephenBedard , thank you for your contribution to the Landing Zone Accelerator! I'm pleased to say this work has been integrated into the code base and will be available in the next major release. I'll close this PR in the meantime. Thank you for your support of the LZA! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The
getLastSuccessfulPipelineExecutionfunction was getting stuck in an infinite loop due to odd behavior from theListPipelineExecutionsAPI returning a nextToken even when there were no more results to get. I've changed this function to make use of theListPipelineExecutionspaginator.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.