Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(crypto): update test code #741

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

nabetti1720
Copy link
Contributor

Description of changes

Just a little improvement to the test code.

  • Delete currently invalid test patterns
  • Add available test patterns

Checklist

  • Created unit tests in tests/unit and/or in Rust for my feature if needed
  • Ran make fix to format JS and apply Clippy auto fixes
  • Made sure my code didn't add any additional warnings: make check
  • Added relevant type info in types/ directory
  • Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@nabetti1720
Copy link
Contributor Author

What's going on? At least it doesn't happen on my laptop (even with the latest toolchain)

image

@richarddavison
Copy link
Contributor

What's going on? At least it doesn't happen on my laptop (even with the latest toolchain)

image

Rust nightly is broken. We can solve this by locking nightly version. I will do so in a PR and this issue should disappear. We can then update nightly version once per month or similar.

@richarddavison
Copy link
Contributor

@nabetti1720 please rebase

@richarddavison richarddavison merged commit 8d118a0 into awslabs:main Dec 16, 2024
11 checks passed
@nabetti1720 nabetti1720 deleted the chore/update-test branch December 18, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants