upgrade aws-sdk to v3 to support webidentitytoken via service account IAM #195
Conversation
hardproblems
changed the title
There was a problem hiding this comment.
Thanks @hardproblems for providing this change!
What versions of Amazon OpenSearch Service did you test against for this? We'll need to be sure that we retain compatibility for 6.x, 7.x, and OpenSearch 1.x.
Also, this plugin is deprecated in favor of logstash-output-opensearch. We can still take this change and should be able to release it. It might be good to additionally make this change in the logstash-output-opensearch plugin which will receive more updates.
|
@dlvenable we built this plugin with 6.8 and tested that it works against ES 6.8 and 7.1. Yea the reason we had to upgrade this one is that we haven't yet upgraded all our ES clusters to 7.x and OpenSearch 1.x and based on opensearch plugin's docs it doesn't officially support ES 6.x |
hardproblems
force-pushed
the
rong--aws-sdk-version-upgrade
branch
from
2129798 to
d3a6672
Compare
|
|
||
| Starting in 7.2.0, the aws sdk version is bumped to v3. In order for all other AWS plugins to work together, please remove pre-installed plugins and install logstash-integration-aws plugin as follows. See also https://github.com/logstash-plugins/logstash-mixin-aws/issues/38 | ||
| ``` | ||
| # Remove existing logstash aws plugins and install logstash-integration-aws to keep sdk dependency the same |
There was a problem hiding this comment.
Thank you for adding this documentation. This is a significant step, so I think it will make sense to have this be a major version bump to 8.0.0. Thoughts? @hardproblems @deepdatta
There was a problem hiding this comment.
major version bump sgtm
There was a problem hiding this comment.
@dlvenable updated. Will port this change to opensearch plugin as well
There was a problem hiding this comment.
opensearch-project/logstash-output-opensearch#171 here's the logic ported over to opensearch
There was a problem hiding this comment.
@hardproblems , Do you still want this one merged?
Issue #, if available:
#169
Description of changes:
Support IMDS by upgrading to the latest version documented in https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts-minimum-sdk.html
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
@dlvenable