Implement directory atime,ctime,mtime #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tem is mounted. Signed-off-by: Ankit Saurabh <sauraank@amazon.co.uk>
sauraank
force-pushed
the
mtimeDirectory
branch
from
2f2e739 to
e6a2dd1
Compare
dannycjones
requested changes
Feb 21, 2023
There was a problem hiding this comment.
We want to broaden these changes to cover all directories and not just the root Inode.
Regarding testing, maybe we can perform a range check on the timestamp returned. We might say the date is within 5 seconds of a given timestamp we assert on, perhaps taken immediately before the superblock creation. You might need to separate the timestamp check from the main assert_inode_stat! macro.
We should update these tests:
Signed-off-by: Ankit Saurabh <sauraank@amazon.co.uk>
dannycjones
reviewed
Feb 22, 2023
Signed-off-by: Ankit Saurabh <sauraank@amazon.co.uk>
dannycjones
reviewed
Feb 23, 2023
Signed-off-by: Ankit Saurabh <sauraank@amazon.co.uk>
dannycjones
requested changes
Feb 24, 2023
Signed-off-by: Ankit Saurabh <sauraank@amazon.co.uk>
dannycjones
requested changes
Feb 24, 2023
Signed-off-by: Ankit Saurabh <sauraank@amazon.co.uk>
dannycjones
approved these changes
Feb 27, 2023
|
FYI there was a flaky test run unrelated to this change, I opened #116. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the directory mtime, ctime, atime to the instant filesystem is mounted, i.e., when the superblock is created. Not sure how to check if its the right current time. Modified the test to include utc_now() in test, but dont think it solves the purpose.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.