Update prefetcher to cancel discarded tasks #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, mountpoint-s3 would not cancel prefetch tasks that it was going to ignore. Instead, they would continue to be polled by the executor despite the results never being checked. This change ensures that the task handles are dropped which cancels the task/future. In the future, we may want to retain some of these tasks where the prefetcher may still be able to make use of them. Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
dannycjones
had a problem deploying
to
PR benchmarks
GitHub Actions
Error
dannycjones
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
dannycjones
changed the title
passaro
approved these changes
Sep 6, 2023
jamesbornholt
approved these changes
Sep 6, 2023
|
Won't fix #488 since this won't cancel the inflight GetObject request, but should help free up some resources spent on checksumming at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Previously, mountpoint-s3 would not cancel prefetch tasks that it was going to ignore. Instead, they would continue to be polled by the executor despite the results never being checked. This could mean up to two (current and at most one "next" GET) would continue to run after the prefetcher had forgotten about them. This change ensures that the task handles are dropped which cancels the task/future.
In the future, we may want to retain some of these tasks where the prefetcher may still be able to make use of them. This refers to the todo comment that is retained from before.
This change was recommended in #488 as a distinct but loosely related issue.
Does this change impact existing behavior?
No breaking changes. This should cancel unused GET requests, freeing up bandwidth for GETs that will be used to fulfill mount-s3 reads.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).